Update plg_system_jooa11y.ini#37048
Closed
particthistle wants to merge 1 commit intojoomla:4.1-devfrom
Closed
Conversation
Punctuation on line 92 resulted in .! Identified in Crowdin by @dyfrig in crowdin comments.
Member
|
Hmm, why not do it the other way, leave the exclamation mark where it is and removing the full stop at the end of the anchor text? |
Contributor
|
Fixed/included in PR #37092. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Punctuation on line 92 resulted in .!
Identified in Crowdin by @dyfrig in crowdin comments.
Pull Request for issue in Crowdin
Summary of Changes
! removed at the end of the string.
Testing Instructions
Minor change - go to where PLG_SYSTEM_JOOA11Y_NEW_TAB_WARNING_TIP is used in the new Joomla 4.1 Accessibility Checker and see that the ! is removed at the end of the best practices link,