[4.2] Turn background image in MM into an img element#36930
Merged
roland-d merged 12 commits intojoomla:4.2-devfrom Feb 10, 2022
Merged
[4.2] Turn background image in MM into an img element#36930roland-d merged 12 commits intojoomla:4.2-devfrom
roland-d merged 12 commits intojoomla:4.2-devfrom
Conversation
Contributor
|
In browser's console when displaying an SVG image.
|
Member
Author
|
Thanks @Quy , fixed it |
Contributor
|
The SVG should display by adding
|
Member
Author
|
All we have in the list is the thumb url, not the full url. But this issue also exists on the 4.2-dev branch. So it needs to be addressed separately. Because there is a general issue how to handle media without a thumbnail. |
dgrammatiko
reviewed
Feb 4, 2022
administrator/components/com_media/resources/scripts/components/browser/items/image.vue
Show resolved
Hide resolved
…a-cms into j42/media/lazy-images
Quy
reviewed
Feb 7, 2022
administrator/components/com_media/resources/scripts/components/browser/items/image.vue
Outdated
Show resolved
Hide resolved
…s/browser/items/image.vue Co-authored-by: Quy <quy@fluxbb.org>
Contributor
|
I have tested this item ✅ successfully on 248ffe6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36930. |
1 similar comment
|
I have tested this item ✅ successfully on 248ffe6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36930. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36930. |
Contributor
|
Thank you, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial pull Request for Issue #36533.
Summary of Changes
Turns the element which shows an image in the media manager from a background div into a propper image element. Full credit for this pr goes to @dgrammatiko as he is the original author in #36550.
Testing Instructions
Actual result BEFORE applying this Pull Request
Image is shown as background image.
Expected result AFTER applying this Pull Request
Image is shown as normal image with loading lazy attribute.