Closed
Conversation
typo and fixes pagebreak plugin
Member
|
I have tested this item ✅ successfully on a0e51f3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36821. |
Contributor
|
I have tested this item ✅ successfully on a0e51f3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36821. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36821. |
Contributor
|
Thanks for the PR. This has to be deprecated in 4.x - 0.1 before 5.0 to be changed in 5.0 to not break extensions using this (I know annoying..). |
Contributor
Author
|
Why? The function is not changing just the default value for the $selector variable |
Contributor
|
Removed RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36821. |
Contributor
Yeah, but if someone is calling it without setting any value, it uses the default value, which is probably not compatible anymore with JS/other code the user applied to this selector. |
Contributor
Author
|
thats a lot of what ifs |
Contributor
Author
|
I was just tyring to help - its not worth the hassle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
typo and fixes pagebreak plugin