Skip to content

[4.1] Fix checked_out value in 4.1.0-2021-11-26.sql and rename to 4.1.0-2021-12-29.sql#36475

Merged
bembelimen merged 2 commits intojoomla:4.1-devfrom
richard67:4.1-dev-fix-jooa11y-update-sql
Dec 29, 2021
Merged

[4.1] Fix checked_out value in 4.1.0-2021-11-26.sql and rename to 4.1.0-2021-12-29.sql#36475
bembelimen merged 2 commits intojoomla:4.1-devfrom
richard67:4.1-dev-fix-jooa11y-update-sql

Conversation

@richard67
Copy link
Copy Markdown
Member

Pull Request for Issue # and #36190 (comment) .

Summary of Changes

Fix the value of the checked_out column in the not yet released update SQL script from PR #36190 .

Rename the script so that it runs when updating from 4.1-beta1 to the future 4.1-beta2 which will contain the changes from PR #36190 .

With the name "4.1.0-2021-11-26.sql" it will not run because the schema version in database of a 4.1-beta1 is already "4.1.0-2021-11-28.sql".

@bembelimen You should have noticed that when merging.

Testing Instructions

  1. On a 4.1-dev or recent 4.1 nightly build which does not yet include the changes from PR [4.1] Joomla-Accessibility Checker (jooa11y). #36190 , run the update SQL statement from that PR, i.e. for MySQL the one here: https://github.com/joomla/joomla-cms/blob/4.1-dev/administrator/components/com_admin/sql/updates/mysql/4.1.0-2021-11-26.sql (of course use the right table name prefix).
  2. Check in the system dashboard if there are checked out extensions, and in com_checkout for which table they are.
    Result: See section "Actual result BEFORE applying this Pull Request" below.
  3. Delete the record in database which you have added in step 1.
  4. Run the SQL statement from the modified update SQL of this PR here (of course use the right table name prefix), e.g. for MySQL:
INSERT INTO `#__extensions` (`name`, `type`, `element`, `folder`, `client_id`, `enabled`, `access`, `protected`, `locked`, `manifest_cache`, `params`, `custom_data`, `checked_out`, `checked_out_time`, `ordering`, `state`) VALUES
('plg_system_jooa11y', 'plugin', 'jooa11y', 'system', 0, 1, 1, 0, 1, '', '', '', NULL, NULL, 0, 0);

Result: See section "Expected result AFTER applying this Pull Request" below.

Actual result BEFORE applying this Pull Request

2021-12-29_checked-out-extension_1

2021-12-29_checked-out-extension_2

Expected result AFTER applying this Pull Request

2021-12-29_checked-out-extension_ok

Documentation Changes Required

None.

@richard67 richard67 changed the title [4.1] Fix checked_out value in 4.1.0-2021-11-26.sql [4.1] Fix checked_out value in 4.1.0-2021-11-26.sql and rename to 4.1.0-2021-12-29.sql Dec 29, 2021
@bembelimen bembelimen added this to the Joomla 4.1 milestone Dec 29, 2021
@khu5h1
Copy link
Copy Markdown
Contributor

khu5h1 commented Dec 29, 2021

I have tested this item ✅ successfully on c583b8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36475.

1 similar comment
@alikon
Copy link
Copy Markdown
Contributor

alikon commented Dec 29, 2021

I have tested this item ✅ successfully on c583b8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36475.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Dec 29, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36475.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 29, 2021
@richard67 richard67 added this to the Joomla 4.1 milestone Dec 29, 2021
@brianteeman
Copy link
Copy Markdown
Contributor

lgtm

@bembelimen bembelimen merged commit 7c05c2b into joomla:4.1-dev Dec 29, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 29, 2021
@bembelimen
Copy link
Copy Markdown
Contributor

Thx

@richard67 richard67 deleted the 4.1-dev-fix-jooa11y-update-sql branch December 29, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants