Skip to content

Trigger full suite of events in com_contact#3630

Closed
wilsonge wants to merge 10 commits intojoomla:stagingfrom
wilsonge:events
Closed

Trigger full suite of events in com_contact#3630
wilsonge wants to merge 10 commits intojoomla:stagingfrom
wilsonge:events

Conversation

@wilsonge
Copy link
Copy Markdown
Contributor

The first part of a bigger set of PR's to try and have more consistent Joomla events triggered. There's also a set of code style fixes as well within the PR.

This PR targets the frontend view of com_contact (and by proxy ALL frontend category views as they use a shared JLayout and JViewCategory class)

Conflicts:
	components/com_contact/views/categories/view.html.php
	components/com_contact/views/category/view.html.php
	components/com_contact/views/contact/view.html.php
	layouts/joomla/content/category_default.php
@brianteeman
Copy link
Copy Markdown
Contributor

@wilsonge after almost a year and with zero comments (probably because of the lack of meaningful description) can this just be closed.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3630.

@Harmageddon
Copy link
Copy Markdown
Contributor

@wilsonge As I need some plugin triggers on com_contact for a project, I just wanted to create a similar PR, until I found this one. Do you mind if I open and test this one or should I rather create a new one?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3630.

@Harmageddon
Copy link
Copy Markdown
Contributor

New PR for this functionality: #8024

@wilsonge
Copy link
Copy Markdown
Contributor Author

wilsonge commented Oct 6, 2015

Hey I'm sorry I never replied on here or glip. I've been running around like crazy the last month with 2 joomla events, a major work deadline and other personal stuff. Thanks so much for taking up me slacking on this!! It's super appreciated!

@wilsonge wilsonge deleted the events branch October 6, 2015 16:33
@Harmageddon
Copy link
Copy Markdown
Contributor

No problem at all, I know these "Why does a day only have 24 hours" phases very well, too. Just had some spare time and thought, I'll just do it. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants