[4] Set HTTP_HOST from CLI#35722
[4] Set HTTP_HOST from CLI#35722alikon wants to merge 3 commits intojoomla:4.0-devfrom alikon:patch-1
Conversation
This comment was marked as abuse.
This comment was marked as abuse.
|
make more sense now ? |
|
@alikon I don't think that it is a good idea to prepare If an object has to use "isClient", then it is a bad signal and it is better to think twice about what we are doing. The problem is the application context mismatch, why the current Application is calling Uri without sending the right parameter. As I pointed out in #35818, the problem is that the Content Component boots the Site Application with About #35625, the problem is that the |
|
I have tested this item ✅ successfully on a510896 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35722. |
|
I have tested this item 🔴 unsuccessfully on a510896 Faking an URL 'localhost' into $_SERVER['HTTP_HOST'] is not the way to solve it. The problem is the "System - Page Cache" plugin executing in the console context. The plugin must ignore the execution when it is in the console context. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35722. |
|
closed as per #35877 merge |
Pull Request for Issue #35625 .
Summary of Changes
set a default
Testing Instructions
before
Notice: Undefined index: HTTP_HOST in /xxx/libraries/src/Uri/Uri.php on line 103
after
No Notice
Documentation Changes Required
no