[4] cleanup more of libraries/vendor before release#34191
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom May 24, 2021
PhilETaylor:build
Merged
[4] cleanup more of libraries/vendor before release#34191wilsonge merged 1 commit intojoomla:4.0-devfrom PhilETaylor:build
wilsonge merged 1 commit intojoomla:4.0-devfrom
PhilETaylor:build
Conversation
Contributor
|
Thanks! |
Contributor
|
FWIW I think a lot of those files are developer depedencies though (e.g. phpunit). Don't forget prod builds are run with |
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
|
Every file counts :) |
Contributor
|
@richard67 this one will require changes to the script.php file - but let's hold and do a final change next weekend or so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code review.
Although this doesnt drastically reduce the size of the final zip files, it does significantly cleanup the libraries/vendor folders removing all kinds of build files that just are not needed on a live Joomla 4.x site.
The complete list of files this deletes are: