Skip to content

[4.0] Fix Select sub-items selects all on Menu Assignment for module#33911

Merged
Quy merged 1 commit intojoomla:4.0-devfrom
joomdonation:fix_menu_assigment
May 16, 2021
Merged

[4.0] Fix Select sub-items selects all on Menu Assignment for module#33911
Quy merged 1 commit intojoomla:4.0-devfrom
joomdonation:fix_menu_assigment

Conversation

@joomdonation
Copy link
Copy Markdown
Contributor

@joomdonation joomdonation commented May 16, 2021

Pull Request for Issue #31277.

Summary of Changes

This PR fixes the issue #31277. Please take a look at the the original issue to understand the issue which this PR tries to solve.

Testing Instructions

  1. See [4] Modules. Menu Assigment. Select sub-items selects all. #31277 , confirm the issue
  2. Download update package for this PR at https://ci.joomla.org/artifacts/joomla/joomla-cms/4.0-dev/33911/downloads/43758/Joomla_4.0.0-beta8-dev+pr.33911-Development-Update_Package.zip, go to System -> Update -> Joomla, upload the update package and install it. Then check and confirm the issue is sorted.

@ghost
Copy link
Copy Markdown

ghost commented May 16, 2021

I have tested this item ✅ successfully on 2d64f8a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33911.

1 similar comment
@ChristineWk
Copy link
Copy Markdown

I have tested this item ✅ successfully on 2d64f8a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33911.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels May 16, 2021
@joomdonation
Copy link
Copy Markdown
Contributor Author

Thanks for testing.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33911.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 16, 2021
@ChristineWk
Copy link
Copy Markdown

Thks to @ReLater and @joomdonation
In the past I always believed that I made wrong selections :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33911.

@joomdonation
Copy link
Copy Markdown
Contributor Author

I thought it is a complicated bug, turned out an easy fix :). Thanks again !

@Quy Quy added this to the Joomla 4.0 milestone May 16, 2021
@Quy Quy merged commit 0dc0f7d into joomla:4.0-dev May 16, 2021
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester and removed RTC This Pull Request is Ready To Commit labels May 16, 2021
@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 16, 2021

Thank you!

@joomdonation joomdonation deleted the fix_menu_assigment branch May 16, 2021 13:49
@ghost
Copy link
Copy Markdown

ghost commented May 16, 2021

As the bot removed RTC shouldn't it reassigne?

@joomdonation
Copy link
Copy Markdown
Contributor Author

@sandramay0905 The PR was merged. So it is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants