[4.0] Bootstrap 5.0.1#33901
Hidden character warning
Conversation
This comment was marked as abuse.
This comment was marked as abuse.
|
is it expected that npm deletes 9,926 rows from package-lock.json? |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
@HLeithner That comes from the lock file format changing back from version 2 to version 1 ( @wilsonge Correct me if that was all wrong what I wrote. |
|
hmm at least it should be consistent and not changed with every pull request |
|
Agree. But what can I do? |
|
If memory serves me right then this is something the production department were going to make a decision on. Either way it doesnt prevent this being merged |
|
@dgrammatiko can you please switch to type 2 format? so we don't jump between the formats? |
|
I have no idea how this can be done. Let me google it |
|
Its pointless |
no idea why you think it's pointless but 🤷 |
|
Because if you look at the history you will see it switching between lockfile 1 and lockfile 2 repeatedly with no errors or issues. Its fine to make a ruling on which version to require but until that date ... |
|
thanks @dgrammatiko |
|
So it turns out that version 2 is not what it's supposed to be here (it implies Node >= 14 && npm >= 7 which are not the project's minis) A fix is to require everybody to use node>= 14 and npm >= 7 Solutions like: will make things a lot more confusing for devs not familiar with nvm etc |
Pull Request for Issue # .
Summary of Changes
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required