Skip to content

[4.0] Bootstrap 5.0.1#33901

Merged
HLeithner merged 1 commit intojoomla:4.0-devfrom
dgrammatiko:—bs5.0.1–4.0-dev
May 15, 2021

Hidden character warning

The head ref may contain hidden characters: "\u2014bs5.0.1\u20134.0-dev"
Merged

[4.0] Bootstrap 5.0.1#33901
HLeithner merged 1 commit intojoomla:4.0-devfrom
dgrammatiko:—bs5.0.1–4.0-dev

Conversation

@dgrammatiko
Copy link
Copy Markdown
Contributor

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels May 15, 2021
@PhilETaylor

This comment was marked as abuse.

@HLeithner
Copy link
Copy Markdown
Member

is it expected that npm deletes 9,926 rows from package-lock.json?

@PhilETaylor

This comment was marked as abuse.

@PhilETaylor

This comment was marked as abuse.

@richard67
Copy link
Copy Markdown
Member

is it expected that npm deletes 9,926 rows from package-lock.json?

@HLeithner That comes from the lock file format changing back from version 2 to version 1 ("lockfileVersion": 1in line 4). Version 2 had lots of additional info like funding information. There still hasn't been made a decision if we change from 1 to 2. The reason why the 4.0-dev branch currently is 2 is because that might have happened with a past PR.

@wilsonge Correct me if that was all wrong what I wrote.

@HLeithner
Copy link
Copy Markdown
Member

hmm at least it should be consistent and not changed with every pull request

@richard67
Copy link
Copy Markdown
Member

Agree. But what can I do?

@brianteeman
Copy link
Copy Markdown
Contributor

If memory serves me right then this is something the production department were going to make a decision on. Either way it doesnt prevent this being merged

@HLeithner
Copy link
Copy Markdown
Member

@dgrammatiko can you please switch to type 2 format? so we don't jump between the formats?

@dgrammatiko
Copy link
Copy Markdown
Contributor Author

I have no idea how this can be done. Let me google it

@brianteeman
Copy link
Copy Markdown
Contributor

Its pointless

@HLeithner
Copy link
Copy Markdown
Member

HLeithner commented May 15, 2021

Its pointless

no idea why you think it's pointless but 🤷

@brianteeman
Copy link
Copy Markdown
Contributor

Because if you look at the history you will see it switching between lockfile 1 and lockfile 2 repeatedly with no errors or issues. Its fine to make a ruling on which version to require but until that date ...

@HLeithner HLeithner merged commit 245cdaa into joomla:4.0-dev May 15, 2021
@HLeithner
Copy link
Copy Markdown
Member

thanks @dgrammatiko
right brian doesn't make sense when I'm the only maintainer that thinks about such things

@dgrammatiko
Copy link
Copy Markdown
Contributor Author

So it turns out that version 2 is not what it's supposed to be here (it implies Node >= 14 && npm >= 7 which are not the project's minis)

A fix is to require everybody to use node>= 14 and npm >= 7
But, a nicer solution is to setup a simple github action that will automatically update the -lock.json (basically only the action will ever update the locks)

Solutions like:
https://stackoverflow.com/questions/64813775/is-there-any-way-to-fix-package-lock-json-lockfileversion-so-npm-uses-a-specific

will make things a lot more confusing for devs not familiar with nvm etc

@dgrammatiko dgrammatiko deleted the —bs5.0.1–4.0-dev branch May 15, 2021 15:13
@zero-24 zero-24 added this to the Joomla 4.0 milestone May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants