[4.0] Fixing ordering of maps in smart search#33885
Merged
HLeithner merged 3 commits intojoomla:4.0-devfrom May 15, 2021
Merged
[4.0] Fixing ordering of maps in smart search#33885HLeithner merged 3 commits intojoomla:4.0-devfrom
HLeithner merged 3 commits intojoomla:4.0-devfrom
Conversation
brianteeman
reviewed
May 14, 2021
|
I have tested this item ✅ successfully on a22b8e7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33885. |
Contributor
|
I have tested this item ✅ successfully on 2436fd7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33885. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 2436fd7 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33885. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33885. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #30965.
Summary of Changes
The maps view is not properly ordering the content, which is mainly because the table has been changed from a flat list to a nested table. Since the rows aren't ordered correctly, tasks like publishing the content are failing. This in turn is due to the code checking if parents are published and if the list of items to publish is not in the right order (parents first), that check fails and the whole process fails. This fixes the ordering (more or less) and thus hopefully fixes the publishing issue for now.
Testing Instructions