[4.0] [Banners] One button for similar actions#33878
Merged
Quy merged 1 commit intojoomla:4.0-devfrom May 15, 2021
Kostelano:4.0-reset-but
Merged
[4.0] [Banners] One button for similar actions#33878Quy merged 1 commit intojoomla:4.0-devfrom Kostelano:4.0-reset-but
Quy merged 1 commit intojoomla:4.0-devfrom
Kostelano:4.0-reset-but
Conversation
|
I have tested this item ✅ successfully on d8d42ee This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33878. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on d8d42ee This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33878. |
Member
|
@brianteeman Do I assume right that the change made by this PR here is ok regarding a11y because the buttons have |
Contributor
|
|
Member
|
Oh, then maybe someone really should check with a screen reader. |
Contributor
|
Changing to just say reset is no different to similar fields where we have create/edit |
Contributor
|
But you don't need to keep asking me for accessibility issues you can ask the accessibility team |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33878. |
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
PR improves the display of reset buttons in the Banners component (see screenshot) + adds a constant that can be used in the future for similar actions.
BEFORE / AFTER
Testing Instructions
Go to the banners component and create a new banner. On the second tab, pay attention to the reset buttons.
Documentation Changes Required
Not