Adapt text and bootstrap size in blog sample data#33866
Merged
HLeithner merged 1 commit intojoomla:4.0-devfrom May 15, 2021
Merged
Adapt text and bootstrap size in blog sample data#33866HLeithner merged 1 commit intojoomla:4.0-devfrom
HLeithner merged 1 commit intojoomla:4.0-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 824afc9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33866. |
Contributor
|
I have tested this item ✅ successfully on 824afc9 Working on your site
Site Information (Statistics) Module
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33866. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33866. |
richard67
reviewed
May 14, 2021
| 'cachemode' => 'static', | ||
| 'module_tag' => 'div', | ||
| 'bootstrap_size' => 6, | ||
| 'bootstrap_size' => 0, |
Member
There was a problem hiding this comment.
Is 0 right? Other modules got 12 in the PR #33045 which you've mentioned.
Member
There was a problem hiding this comment.
@brianteeman Maybe you can advise me if zero is the right value here or if it should be 12?
Member
There was a problem hiding this comment.
Assuming zero means default and will result in 12, I will set this PR RTC.
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33866. |
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #33832 .
Summary of Changes
Change text to "To totally change the look of your site you will probably want to install a new template. Go to System, select Install - Extensions from the list and the extension installer will open. There are many free"
Bootstrap size of module site information is set to 0, to fit recently made changes in dashboard modules. #33045 et alii
Testing Instructions
Code review or install blog sample data,
Front end : Log in and and check the text "Working on your Site"
Backend: Check the with of the module site information
Actual result BEFORE applying this Pull Request
Module site information has boostrap size 6 and has only half the width of the column
Text see #33832 .
Expected result AFTER applying this Pull Request
Module site information has same size as other modules
Text is correct for J4
Documentation Changes Required