Skip to content

[4.0] Rename Check and Install button#33855

Merged
rdeutz merged 1 commit intojoomla:4.0-devfrom
Quy:check-install
May 14, 2021
Merged

[4.0] Rename Check and Install button#33855
rdeutz merged 1 commit intojoomla:4.0-devfrom
Quy:check-install

Conversation

@Quy
Copy link
Copy Markdown
Contributor

@Quy Quy commented May 13, 2021

Summary of Changes

For consistency, the usage of and with & in Upload & Install and Save & Close, rename Check and Install to Check & Install.

Testing Instructions

System > Install > Extensions
Click Install from Folder tab.
See Check and Install button.
Click Install from URL tab.
See Check and Install button.

System > Update >Joomla
Click Upload & Update tab.
See Upload & Install button.

Apply PR.

Actual result BEFORE applying this Pull Request

Check and Install

Expected result AFTER applying this Pull Request

Check & Install

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels May 13, 2021
@ghost
Copy link
Copy Markdown

ghost commented May 14, 2021

I have tested this item ✅ successfully on 88edf93


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33855.

1 similar comment
@rjharishabh
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 88edf93


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33855.

@Abernyte-Git
Copy link
Copy Markdown

I have tested this item ✅ successfully on 88edf93

Test successful but on a grammatical note is this the correct use of ampersand. I was always taught that it should only be used where the words are naturally co-joined in a well known phrase like "Research & Development"


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33855.

@richard67
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33855.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 14, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone May 14, 2021
@rdeutz rdeutz merged commit 07f6151 into joomla:4.0-dev May 14, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 14, 2021
@Quy Quy deleted the check-install branch May 14, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants