Skip to content

[4.0] cassiopeia font note#33851

Merged
HLeithner merged 2 commits intojoomla:4.0-devfrom
brianteeman:note
May 15, 2021
Merged

[4.0] cassiopeia font note#33851
HLeithner merged 2 commits intojoomla:4.0-devfrom
brianteeman:note

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

Adds a title and formatting

Pull Request for Issue #33846

Before

image

After

image

Adds a title and formatting
@ChristineWk
Copy link
Copy Markdown

I have tested this item ✅ successfully on 273fdc2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33851.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 13, 2021

33851

@brianteeman
Copy link
Copy Markdown
Contributor Author

grrrh

that was my (obviously) failed attempt at having an h4 in the same colour scheme as the message.

@ghost
Copy link
Copy Markdown

ghost commented May 14, 2021

I have tested this item ✅ successfully on 273fdc2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33851.

@richard67
Copy link
Copy Markdown
Member

@brianteeman Will you fix @Quy 's finding?

@richard67 richard67 added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label May 14, 2021
@brianteeman
Copy link
Copy Markdown
Contributor Author

yes

@joomla-cms-bot joomla-cms-bot removed the Language Change This is for Translators label May 14, 2021
@richard67 richard67 removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label May 14, 2021
@brianteeman
Copy link
Copy Markdown
Contributor Author

As far as I can tell there is no option available to have a title AND for it to inherit the colors. So for now this PR just resolves the formatting issue and should look like
image

@ghost
Copy link
Copy Markdown

ghost commented May 14, 2021

I have tested this item ✅ successfully on feff360


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33851.

1 similar comment
@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 14, 2021

I have tested this item ✅ successfully on feff360


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33851.

@Quy Quy added the Language Change This is for Translators label May 14, 2021
@Quy
Copy link
Copy Markdown
Contributor

Quy commented May 14, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33851.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 14, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone May 14, 2021
@HLeithner HLeithner merged commit fc87030 into joomla:4.0-dev May 15, 2021
@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators RTC This Pull Request is Ready To Commit labels May 15, 2021
@brianteeman
Copy link
Copy Markdown
Contributor Author

thx

@brianteeman brianteeman deleted the note branch May 15, 2021 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants