Fix of vertical line not having height#33821
Merged
rdeutz merged 2 commits intojoomla:4.0-devfrom May 14, 2021
Merged
Conversation
Contributor
|
Wasnt this by design? |
Member
|
@eopws Code style error reported by drone in the scss-cs step, i.e. scss code style: |
Made this because of linter asks to do it
Author
I don't think so, because the line was created to separate sidebar from content and logically should be extended to the bottom |
Contributor
|
perhaps, perhaps not |
Contributor
|
I have tested this item ✅ successfully on 7468f97 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33821. |
Contributor
|
I have tested this item ✅ successfully on 7468f97 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33821. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33821. |
Contributor
|
So much for waiting for feedback to see if it was by design. Just because something gets two successful tests does not mean it should be merged. |
Contributor
|
From a design perspective I would say this was indeed an issue to be fixed 👍 |
Contributor
|
Thank you for confirming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #33809.
Summary of Changes
Vertical line that separates sidebar from content is extended to bottom (see screenshots and issue)
Testing Instructions
Go to Global Configuration > any component
Actual result BEFORE applying this Pull Request
The vertical line lack of height
Expected result AFTER applying this Pull Request
Everything is fine with height
