[4.0] Joomla style tooltip in com_redirect#33748
Merged
chmst merged 7 commits intojoomla:4.0-devfrom May 12, 2021
rjharishabh:tooltip-redirect
Merged
[4.0] Joomla style tooltip in com_redirect#33748chmst merged 7 commits intojoomla:4.0-devfrom rjharishabh:tooltip-redirect
chmst merged 7 commits intojoomla:4.0-devfrom
rjharishabh:tooltip-redirect
Conversation
Contributor
|
Duplicate
|
Contributor
Author
|
@Quy can I change |
Contributor
|
Please checkout Banners to see how it is done using |
Contributor
Author
|
Banners use this |
Contributor
|
I’m not at a computer to confirm but yes that should be fine. |
Contributor
|
@rjharishabh you also con compare this one: #33557 |
Contributor
|
Please add |
Contributor
|
I have tested this item ✅ successfully on 246a7af This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33748. |
1 similar comment
|
I have tested this item ✅ successfully on 246a7af This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33748. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33748. |
Contributor
|
Thanks! |
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #.
Summary of Changes
Remove
btn-groupbecause of no use here (IMO)Add
div role="tooltip"Testing Instructions
Dashboard>System>Redirects under ManageIf your site doesn't have any redirects, please create some redirects using
NewActual result BEFORE applying this Pull Request
tooltip-before.mp4
Expected result AFTER applying this Pull Request
tooltip-after.mp4
Documentation Changes Required
No