[4.0] Fix JS errors for com_joomlaupdate#33488
Conversation
|
@joomdonation It needs to fix javascript-cs, see https://ci.joomla.org/joomla/joomla-cms/42929/1/21 . |
administrator/components/com_joomlaupdate/tmpl/joomlaupdate/default_preupdatecheck.php
Outdated
Show resolved
Hide resolved
administrator/components/com_joomlaupdate/tmpl/joomlaupdate/default_preupdatecheck.php
Outdated
Show resolved
Hide resolved
|
@wilsonge As of right now, all the errors are fixed and I would say that it works in the same way with what we are having on 3.10.0. You can review the code and get it merged (I made basic test by installing older version of Akeeba Backup and JCE editor for testing) However, there are still some problems:
Basically, from what I understand, the loop over all the none core plugins and if that plugin belong to an extension, remove it from the array. But that could cause all plugins load being checked (causes by the removal mentioned). Maybe you can ask the developer who worked on the feature to take a look at it. |
George had asked me to fix this after the BS js PR but I never made a PR because my solution (SPA basically)was touching the restore.php and that wasn't a discussion I wanted myself involved. This is (I think) the repo: https://github.com/joomla/joomla-cms/compare/4.0-dev...dgrammatiko:4.0-dev_joomlaUpdate?expand=1 At the very least check the changes in the controller and the way I pass data from PHP to JS. The current state is god awful... |
|
@dgrammatiko I haven't spent time to read the whole code to understand the process, so I could not comment on your solution right now. However, if you make a PR, I would be happy to review and test it. The current code is not looking good, I agree. |
|
Starting to look better. Thanks for fixing my mess trying to port this! |
|
This is clearly an improvement merging this now |
Pull Request for Issue # .
Summary of Changes
There are currently many js errors in com_joomlaupdate. This PR attempts to fix this.
Testing Instructions
I'm unsure as I don't understand fully how pre-update checks in com_joomlaupdate works yet. Maybe for now, code review would be enough because the current code is already broken.