[4.0] Make check for package ID or extension ID type safe in pre-update-check javascript#33487
Closed
richard67 wants to merge 3 commits intojoomla:4.0-devfrom
Closed
Conversation
This was referenced May 2, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #33477 (part) .
Summary of Changes
parseIntto get values fromdata-extension-idand thepackage_idandextension_idproperties of the particular non-core extension object.parseIntfromdata-extension-iddefault to zero in order not to match withNaNin later type safe comparison.data-extension-idwith thepackage_idand theextension_idproperties of the non-core extension.Testing Instructions
Will be added soon.
Actual result BEFORE applying this Pull Request
The pre-update check works more or less in the 4.0-dev branch after the recent upmerge from 3.10-dev.
The javascript cs in drone fails due to type safe comparison being required.
Expected result AFTER applying this Pull Request
The pre-update check works as well or bad as without this PR.
The javascript cs in drone passes.
Documentation Changes Required
None.
Question
@zero-24 @wilsonge Should that be done in 3.10-dev, too?