Skip to content

[4.0] Field contexts filter improvement#33387

Merged
drmenzelit merged 2 commits intojoomla:4.0-devfrom
joomdonation:field_contexts_filter_improvement
Apr 28, 2021
Merged

[4.0] Field contexts filter improvement#33387
drmenzelit merged 2 commits intojoomla:4.0-devfrom
joomdonation:field_contexts_filter_improvement

Conversation

@joomdonation
Copy link
Copy Markdown
Contributor

@joomdonation joomdonation commented Apr 28, 2021

Pull Request for Issue #33368, alternative for #33372

Summary of Changes

This PR modifies code so that the field contexts filter will only be displayed if there are more than one option. Compare to #33372, it also remove the unnecessary mark up, so it is a bit better.

Testing Instructions

  1. Apply patch
  2. Go to Content -> Fields, Content -> Field Groups, make sure you still see contexts filter (contains Articles, Category).
  3. Go to Users -> Fields, Users -> Field Groups, make sure you do not see the filter anymore (before, the filter only contains on option Users ,so it is useless)
  4. Go to Users -> Fields, view source of the page, make sure you don't see the useless mark up which @Quy mentioned here [4.0] Remove users dropdown in fields and field-groups #33372 (comment)

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Apr 28, 2021

I have tested this item ✅ successfully on e111401

Perfect! Thank you!!!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33387.

@rjharishabh
Copy link
Copy Markdown
Contributor

rjharishabh commented Apr 28, 2021

I have tested this item ✅ successfully on e111401

Superb! Thank you


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33387.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Apr 28, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33387.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 28, 2021
@drmenzelit drmenzelit merged commit 0a982c8 into joomla:4.0-dev Apr 28, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 28, 2021
@drmenzelit
Copy link
Copy Markdown
Collaborator

Thanks!

@joomdonation joomdonation deleted the field_contexts_filter_improvement branch April 28, 2021 10:17
@Quy Quy added this to the Joomla 4.0 milestone Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants