Skip to content

[4.0] Add png to default values#33345

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
Quy:templates-config
Apr 26, 2021
Merged

[4.0] Add png to default values#33345
wilsonge merged 1 commit intojoomla:4.0-devfrom
Quy:templates-config

Conversation

@Quy
Copy link
Copy Markdown
Contributor

@Quy Quy commented Apr 26, 2021

Summary of Changes

The default values of Valid Image Formats is missing png.

Testing Instructions

Go to Global Configuration > Templates
Values of Valid Image Formats: gif,bmp,jpg,jpeg,png,webp
Clear values.
Click Save button.
Values of Valid Image Formats missing png: gif,bmp,jpg,jpeg,webp
Apply PR.
Clear values.
Click Save button.
Values of Valid Image Formats with png: gif,bmp,jpg,jpeg,png,webp

Actual result BEFORE applying this Pull Request

gif,bmp,jpg,jpeg,webp

Expected result AFTER applying this Pull Request

gif,bmp,jpg,jpeg,png,webp

@YatharthVyas
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on c7db433


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33345.

1 similar comment
@ChristineWk
Copy link
Copy Markdown

I have tested this item ✅ successfully on c7db433


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33345.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Apr 26, 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33345.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 26, 2021
@Quy Quy added PR-4.0-dev RTC This Pull Request is Ready To Commit and removed RTC This Pull Request is Ready To Commit labels Apr 26, 2021
@Quy Quy added this to the Joomla 4.0 milestone Apr 26, 2021
@wilsonge wilsonge merged commit adad8e2 into joomla:4.0-dev Apr 26, 2021
@wilsonge
Copy link
Copy Markdown
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 26, 2021
@Quy Quy deleted the templates-config branch April 26, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants