[4.0] Add bottom-margin in vote#33340
Merged
chmst merged 2 commits intojoomla:4.0-devfrom Apr 27, 2021
rjharishabh:padding-vote
Merged
[4.0] Add bottom-margin in vote#33340chmst merged 2 commits intojoomla:4.0-devfrom rjharishabh:padding-vote
chmst merged 2 commits intojoomla:4.0-devfrom
rjharishabh:padding-vote
Conversation
|
I have tested this item ✅ successfully on d7ee344 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33340. |
Member
|
Best practise is to use margins for block separation |
Contributor
Author
|
Thanks @C-Lodder |
Contributor
|
I have tested this item ✅ successfully on f6b377b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33340. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on f6b377b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33340. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33340. |
Contributor
|
Thanks! |
Contributor
Author
|
Thanks everyone |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #33337.
Summary of Changes
Add
mb-2in the voting formTesting Instructions
position-topAnd see the changes
Actual result BEFORE applying this Pull Request
No bottom padding applied in vote form
Expected result AFTER applying this Pull Request
Bottom padding applied in vote form
Documentation Changes Required
None