Skip to content

[4.0] REST semantic Provide Sensible Resource Names#33339

Merged
wilsonge merged 5 commits intojoomla:4.0-devfrom
alikon:patch-126
May 15, 2021
Merged

[4.0] REST semantic Provide Sensible Resource Names#33339
wilsonge merged 5 commits intojoomla:4.0-devfrom
alikon:patch-126

Conversation

@alikon
Copy link
Copy Markdown
Contributor

@alikon alikon commented Apr 26, 2021

Pull Request for Issue #33336 .

Summary of Changes

from GET /api/index.php/v1/installer/manage
to GET /api/index.php/v1/extensions

Testing Instructions

read #33336
or test the endpoint :

  • GET {{base_path}}/api/index.php/v1/extensions?core=true/false
  • GET {{base_path}}/api/index.php/v1/extensions?status=0/1
  • GET {{base_path}}/api/index.php/v1/extensions?type=component/plugin/module/template

Documentation Changes Required

already undocumented but should be

@alikon alikon marked this pull request as ready for review April 26, 2021 17:27
@alikon alikon requested a review from wilsonge April 26, 2021 17:28
@anibalsanchez
Copy link
Copy Markdown
Contributor

anibalsanchez commented May 1, 2021

I have tested this item 🔴 unsuccessfully on 9b7acd4

It seems that I always get the same response and it doesn't use the filters:

curl -H "Authorization: Bearer ...." -X GET "http://.../api/index.php/v1/extensions?core=true"

curl -H "Authorization: Bearer ..." -X GET "http://.../api/index.php/v1/extensions?core=false"

curl -H "Authorization: Bearer ..." -X GET "http://.../api/index.php/v1/extensions?status=1"

curl -H "Authorization: Bearer ..." -X GET "http://.../api/index.php/v1/extensions?status=0"

@alikon
Copy link
Copy Markdown
Contributor Author

alikon commented May 9, 2021

@anibalsanchez can you please retest, now just 1 pr 😃

@carcam
Copy link
Copy Markdown

carcam commented May 14, 2021

I have tested this item ✅ successfully on 3404118

I have tested the 3 poposed endpoints with their filters and it returns different content according to each of the proposed filters.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33339.

@BertaOctech
Copy link
Copy Markdown

I have tested this item ✅ successfully on 3404118

Before applying the patch I did not manage to get any answer from the API
After applying the patch, I got correct filtered data in response to

curl -H "Authorization: Bearer XXXXXX" http://localhost/demo_j4/api/index.php/v1/extensions?status=1

and

curl -H "Authorization: Bearer XXXXXX" http://localhost/demo_j4/api/index.php/v1/extensions?status=0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33339.

@richard67
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33339.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 14, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone May 14, 2021
@wilsonge wilsonge merged commit 2bf13ca into joomla:4.0-dev May 15, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 15, 2021
@wilsonge
Copy link
Copy Markdown
Contributor

Thanks!

@alikon alikon deleted the patch-126 branch May 17, 2021 06:34
@PhilETaylor

This comment was marked as abuse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants