[4.0] Postinstall reset hide fix#33338
Merged
chmst merged 3 commits intojoomla:4.0-devfrom Apr 27, 2021
Merged
Conversation
The $eid was always assigned 212 (ID of Joomla CMS) by ` $model->getState('eid', $model->getJoomlaFilesExtensionId())`
Now, this value is dynamically assigned based on the value of `#adminForm`'s eid input field (extension options dropdown field)
$eid was always assigned the value of 212 (ID of Joomla CMS) by `getJoomlaFilesExtensionId())` Now it dynamically takes the id from the URL parameters. Also, removed line 39 as the PHPCS suggested I do so.
administrator/components/com_postinstall/src/Controller/MessageController.php
Outdated
Show resolved
Hide resolved
administrator/components/com_postinstall/src/Controller/MessageController.php
Outdated
Show resolved
Hide resolved
Contributor
|
I have tested this item ✅ successfully on a416ce9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33338. |
Contributor
|
I have tested this item ✅ successfully on a416ce9 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33338. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33338. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #33307.
All the 6 mentioned problems are fixed by this PR.
Summary of Changes
The $eid variable was assigned it's value by
$model->getJoomlaFilesExtensionId())which always returns the ID of Joomla CMS (212). This was causing the form to behave strangely by not considering the value of the selected extension from the dropdownTesting Instructions
Step 1: Run this SQL to add a fake post installation message (change the db prefix!)
Step 2: Visit the Post Installation Message screen and follow through:
Before the PR
After the PR:
Problem 1: Atum's page will be shown on reload and messages will be hidden
Problem 2: Atum's messages won't be visible
Problem 3: Messages shown will be of Atum
Problem 4: Page will reload to display Atum's messages
Problem 5: Reset will only affect Atum's messages
Problem 6: Atum's messages will be displayed
The Problems and fixes mentioned above are shown in the video below.
Actual result BEFORE applying this Pull Request
pr_before_post_hide.mp4
Expected result AFTER applying this Pull Request
pr_post_hide.mp4
Documentation Changes Required
None