[4] Rename recent BlankState feature to EmptyState#33334
Merged
HLeithner merged 6 commits intojoomla:4.0-devfrom Apr 27, 2021
PhilETaylor:renameblankstate
Merged
[4] Rename recent BlankState feature to EmptyState#33334HLeithner merged 6 commits intojoomla:4.0-devfrom PhilETaylor:renameblankstate
HLeithner merged 6 commits intojoomla:4.0-devfrom
PhilETaylor:renameblankstate
Conversation
Bakual
approved these changes
Apr 26, 2021
Member
|
That's the rename of the layouts. But what about these |
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
|
Please rename the language constants too. |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
Quy
reviewed
Apr 26, 2021
This comment was marked as abuse.
This comment was marked as abuse.
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
|
feeling guilty... 😨 |
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
|
nevermind |
Quy
reviewed
Apr 26, 2021
Contributor
|
I have tested this item ✅ successfully on 6ed02ba This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33334. |
Contributor
You're welcome 🤣 |
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
|
It was a pleasure (really!) :) |
Contributor
|
I have tested this item ✅ successfully on 6ed02ba This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33334. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33334. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The concept we are implementing is called Empty State design, therefore it makes sense to use that term throughout and not to confuse people with "Blank state/Blank slate" terms. Sorry, that was my fault.
Therefore at this early stage it makes sense to get our own house in order from the start and use the term "Empty State" to refer to the "Empty State Design UX" we are employing.
References (just a quick google):