[4] Add icons back to refactored blank state#33333
Merged
Quy merged 1 commit intojoomla:4.0-devfrom Apr 26, 2021
PhilETaylor:blankstateicons
Merged
[4] Add icons back to refactored blank state#33333Quy merged 1 commit intojoomla:4.0-devfrom PhilETaylor:blankstateicons
Quy merged 1 commit intojoomla:4.0-devfrom
PhilETaylor:blankstateicons
Conversation
Signed-off-by: Phil E. Taylor <phil@phil-taylor.com>
Contributor
|
I have tested this item ✅ successfully on 98876c8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33333. |
Bakual
approved these changes
Apr 26, 2021
Contributor
|
I have tested this item ✅ successfully on 98876c8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33333. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33333. |
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #33328 Replacement for #33332
Summary of Changes
Adding the icon to the $displayData. The icon will default to the article one if none is given.
Restoring the original icons for the various blankstate layouts (eg contacts, newsfeeds, banners, user notes, ...)
Testing Instructions
Check the various views when no item is created yet and see what icon is used in the blankstate layout.
Actual result BEFORE applying this Pull Request
Always the same icon (copy) is used
Expected result AFTER applying this Pull Request
The views have different icons matching the context.
Documentation Changes Required
None