[4.0] Dont show create button in blankstate layout when loaded in a modal#33331
Merged
Quy merged 1 commit intojoomla:4.0-devfrom Apr 26, 2021
Merged
[4.0] Dont show create button in blankstate layout when loaded in a modal#33331Quy merged 1 commit intojoomla:4.0-devfrom
Quy merged 1 commit intojoomla:4.0-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 974780c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33331. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 974780c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33331. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33331. |
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #33319 .
Summary of Changes
Don't show the create button when the blankstate layout is loaded in a modal. Eg when using the "Select" button in a single article menuitem.
In modals, we also don't show the toolbar buttons, so this makes most sense to me.
Testing Instructions
Brian did a good video to show the issue in #33319
Actual result BEFORE applying this Pull Request
Create button is shown in modal
Expected result AFTER applying this Pull Request
Create button is not shown in modal
Documentation Changes Required
None