Skip to content

[4] Remove deprecated function calls and use short array syntax#33322

Merged
rdeutz merged 2 commits intojoomla:4.0-devfrom
PhilETaylor:cleanuplayoutcodes
Apr 26, 2021
Merged

[4] Remove deprecated function calls and use short array syntax#33322
rdeutz merged 2 commits intojoomla:4.0-devfrom
PhilETaylor:cleanuplayoutcodes

Conversation

@PhilETaylor
Copy link
Copy Markdown
Contributor

@PhilETaylor PhilETaylor commented Apr 25, 2021

Summary of Changes

Remove deprecated function calls and use short array syntax

Instead of Factory::getUser() which is deprecated use Factory::getApplication()->getIdentity()

Use short array syntax [] instead of long syntax array()

Testing Instructions

Code Review only

@Bakual :)

Copy link
Copy Markdown
Contributor

@Bakual Bakual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, fine for me!

@richard67
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on edabb1a

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33322.

@joomdonation
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on edabb1a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33322.

@richard67
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33322.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 26, 2021
@richard67 richard67 added this to the Joomla 4.0 milestone Apr 26, 2021
@rdeutz rdeutz merged commit 6318f39 into joomla:4.0-dev Apr 26, 2021
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants