Merged
Conversation
The cancel button should have the text Cancel when its a new item Close when its an existing item With this PR I have fixed the few instances that incorrectly did not follow this pattern which is used in all the other 33 views. Summary of changes Create a New Article - Cancel Edit an Article - Close Create a Workflow - Cancel Edit a Workflow - Close Create a Workflow Stage - Cancel Edit a Workflow Stage - Close Create a Workflow Transition - Cancel Edit a Workflow Transition - Close Edit an image - Close Create a private message - Close Read a private message - Close
Member
|
@brianteeman I've just tested: 2 of the things in your list don't work for me:
The rest is as described. |
Quy
reviewed
Apr 25, 2021
Contributor
Author
|
Article should be fixed now. Its slightly different in that component for reasons that are beyond me. fixed typo in description |
Member
|
I have tested this item ✅ successfully on 013a5e6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33317. |
richard67
reviewed
Apr 25, 2021
administrator/components/com_content/src/View/Article/HtmlView.php
Outdated
Show resolved
Hide resolved
Member
|
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33317. |
Member
|
Please fix PHP CS as suggested above. |
Member
|
I have tested this item ✅ successfully on d8397ab This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33317. |
1 similar comment
|
I have tested this item ✅ successfully on d8397ab This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33317. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/33317. |
Contributor
|
Thanks |
Contributor
Author
|
thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cancel button should have the text
Cancel when its a new item
Close when its an existing item
With this PR I have fixed the few instances that incorrectly did not follow this pattern which is used in all the other 33 views.
Summary of changes
Create a New Article - Cancel
Edit an Article - Close
Create a Workflow - Cancel
Edit a Workflow - Close
Create a Workflow Stage - Cancel
Edit a Workflow Stage - Close
Create a Workflow Transition - Cancel
Edit a Workflow Transition - Close
Edit an image - Close
Create a private message - Cancel
Read a private message - Close