Make sure we don't allow IP overrides within the com_content vote feature#32452
Closed
zero-24 wants to merge 2 commits intojoomla:stagingfrom
Closed
Make sure we don't allow IP overrides within the com_content vote feature#32452zero-24 wants to merge 2 commits intojoomla:stagingfrom
zero-24 wants to merge 2 commits intojoomla:stagingfrom
Conversation
richard67
reviewed
Feb 17, 2021
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Member
|
I have tested this item ✅ successfully on 8b0103e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32452. |
Contributor
|
For the test I changed the following code in The test remains successful. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/32452. |
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
|
and that will include joomla.org |
Contributor
Author
|
Understood. I'm happy to hear proposals to fix this issue. We might have to do some kind of configuration where we get the info from that we run behind that proxy setup? |
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
Maybe you can do something with this, see: |
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
Author
|
Its about bypassing the ip restrictions on voting by bypassing it using the mentiond headers. |
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
This comment was marked as abuse.
Contributor
Author
|
see: #32866 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for an issue reported to the JSST by DangKhai from Viettel Cyber Security
Summary of Changes
Make sure we dont allow IP overrides by the X-Forwarded-For or Client-Ip HTTP headers for the com_content vote feature.
Testing Instructions
Setup voting for an article
make sure voting works
apply the patch
make sure voting still works
Actual result BEFORE applying this Pull Request
It was possible to override the ip using the X-Forwarded-For or Client-Ip HTTP headers
Expected result AFTER applying this Pull Request
that behavior is disabled now
Documentation Changes Required
None