Merged
Conversation
This PR reverts an accidental change made in joomla#30784 to make the intro image a link only when the option is set. This is an important accessibility issue. For full testing instructions etc see the original PR where this was introduced joomla#30823
Contributor
|
I have tested this item ✅ successfully on 41e565c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31576. |
1 similar comment
|
I have tested this item ✅ successfully on 41e565c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31576. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31576. |
Contributor
|
Thanks! |
Contributor
Author
|
thanks - lets hope it doesnt get overwritten again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts an accidental change made in #30784 to make the intro image a link only when the option is set and to ensure that a link has a title. This is an important accessibility issue.
For full testing instructions etc see the original PR where this was introduced #30823
cc @carcam