[4.0] media manager fix inconsistent select#31427
Merged
HLeithner merged 3 commits intojoomla:4.0-devfrom Nov 21, 2020
Merged
Conversation
This was referenced Nov 18, 2020
Contributor
|
I have tested this item ✅ successfully on fa42716 Needs npm i This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31427. |
|
I have tested this item ✅ successfully on fa42716 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31427. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31427. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #30784 (comment)
Summary of Changes
Bug fix: The select box should respond to the same event as the thumb.
Testing Instructions
Edit an article and either try to set a fulltext/intro image or insert an image through the editor button.
Click around, selecting folder, image, clicking on the tick box, etc. The additional data should appear/disappear depending on the selected file (only on selected images). The next comment/gif might be helpful:
Actual result BEFORE applying this Pull Request
Inconsistent behaviour
Expected result AFTER applying this Pull Request
All good
Documentation Changes Required
No bug fix