Skip to content

[4.0] Propose s/cachable/cacheable #29812

Closed
PhilETaylor wants to merge 5 commits intojoomla:4.0-devfrom
PhilETaylor:cachable
Closed

[4.0] Propose s/cachable/cacheable #29812
PhilETaylor wants to merge 5 commits intojoomla:4.0-devfrom
PhilETaylor:cachable

Conversation

@PhilETaylor
Copy link
Copy Markdown
Contributor

@PhilETaylor PhilETaylor commented Jun 28, 2020

Summary of Changes

Proposing the fixing of the long term typo of cachable to be fixed in the new major series of Joomla 4

It shouldn't be a b/c break as its just a variable name but @HLeithner says

Only thing to consider is that this method is abstracted by 3rd party developer and we should check this before we make a b/c break. I don't know if we have property/option arrays with cachable in the code base.

Testing Instructions

TEST EVERYTHING ;-)

Actual result BEFORE applying this Pull Request

EVERYTHING Works

Expected result AFTER applying this Pull Request

EVERYTHING Works

Documentation Changes Required

Maybe a note in the https://docs.joomla.org/Potential_backward_compatibility_issues_in_Joomla_4 ?

@brianteeman brianteeman mentioned this pull request Jun 28, 2020
Merged
Phil E. Taylor added 2 commits June 29, 2020 17:23
@Razzo1987
Copy link
Copy Markdown
Contributor

Razzo1987 commented Oct 17, 2020

After apply the patch on this file remains cachable:

components/com_tags/src/Controller/DisplayController.php
components/com_finder/src/Controller/DisplayController.php
components/com_newsfeeds/src/Controller/DisplayController.php
components/com_privacy/src/Controller/DisplayController.php
components/com_users/src/Controller/DisplayController.php
components/com_content/src/Controller/DisplayController.php
components/com_wrapper/src/Controller/DisplayController.php
libraries/src/MVC/Controller/BaseController.php
libraries/vendor/joomla/application/src/WebApplicationInterface.php
libraries/vendor/joomla/application/src/AbstractWebApplication.php

I think the branch must be updated because you fix it

@ceford
Copy link
Copy Markdown
Contributor

ceford commented Nov 18, 2020 •
edited
Loading

There are 107 instances in php files before applying the pr and 39 after. As this is a variable name it seems to me it may as well be all or nothing. Only where it occurs as $cachable.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29812.

@brianteeman brianteeman mentioned this pull request Aug 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quy Quy Quy left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PhilETaylor @Razzo1987 @ceford @Quy @joomla-cms-bot