Skip to content

[4.0] Fix notice sitename in error_login.php#28518

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
chmst:fix-notice-error-login
Mar 31, 2020
Merged

[4.0] Fix notice sitename in error_login.php#28518
wilsonge merged 1 commit intojoomla:4.0-devfrom
chmst:fix-notice-error-login

Conversation

@chmst
Copy link
Copy Markdown
Contributor

@chmst chmst commented Mar 30, 2020

Summary of Changes

Fix notice in atum error-login.php
Notice: Undefined variable: sitename in administrator\templates\atum\error_login.php on line 105

Testing Instructions

Inspect code.
Or delete line 22 in login.php, so enforcing the output of the error_login.php.

@chmst chmst changed the title Fix notice sitename [4.0] Fix notice sitename in error_login.php Mar 30, 2020
@ChristineWk
Copy link
Copy Markdown

I have tested this item ✅ successfully on 2abe239

code inspected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28518.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Mar 31, 2020

I have tested this item ✅ successfully on 2abe239

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28518.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Mar 31, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28518.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 31, 2020
@wilsonge wilsonge merged commit 786f742 into joomla:4.0-dev Mar 31, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Mar 31, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 31, 2020
@chmst chmst deleted the fix-notice-error-login branch April 19, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants