[4.0] Cleanup Component Dispatchers#28507
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Mar 30, 2020
Merged
Conversation
5315a66 to
f0999d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
CMSApplicationInterfacerather than the concreteCMSApplicationclass (the module dispatcher was incorrectly using it already but after [4.0] Add getLanguage to application interface and cleanup console/cli apps #28506 is merged all will be fine there).Testing Instructions
Check the Joomla components still load correctly. No changes expected in the interface
Documentation Changes Required
Nothing new - docs will be added when the dispatcher class itself is documented