[4.0] Exception handler with debug enabled, second try#28494
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Mar 30, 2020
Merged
[4.0] Exception handler with debug enabled, second try#28494wilsonge merged 2 commits intojoomla:4.0-devfrom
wilsonge merged 2 commits intojoomla:4.0-devfrom
Conversation
Contributor
|
I just noticed this is missing touching the api/includes/framework.php file (and was previously too) - can we fix that please? |
Member
Author
|
I was not sure if it need there, |
Contributor
|
We're going to ideally pipe out as JSON instead of HTML but yes we want the same error handling levels etc. and HTML is fine for the first pass |
Member
Author
|
added |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix for #27632
Since internal changes in
Symfony\Component\ErrorHandler\ErrorHandlermy previous changes #27632 make no sense anymore 😃@wilsonge sorry for confusing
Testing Instructions
Please repeat test from #27632
Expected result
You should be able to see exception message with trace when Debug enabled
Actual result
You see only "Oops! An Error Occurred"