Skip to content

[4.0] Fix overflow in modal#28487

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
Quy:26638-modal-overflow
Mar 28, 2020
Merged

[4.0] Fix overflow in modal#28487
wilsonge merged 1 commit intojoomla:4.0-devfrom
Quy:26638-modal-overflow

Conversation

@Quy
Copy link
Copy Markdown
Contributor

@Quy Quy commented Mar 27, 2020

Pull Request for Issue #26638.

Summary of Changes

Fix text from overflowing in modal.

Testing Instructions

Go to System > Site Templates > Cassiopeia Details and Files
Edit error.php
Click on New File
Apply PR
Run npm i

Actual result

67140193-ada6dc80-f275-11e9-89b3-83fcf6174e4a

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 27, 2020
@Quy Quy mentioned this pull request Mar 27, 2020
@infograf768
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on de80493


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28487.

1 similar comment
@roland-d
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on de80493


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28487.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 28, 2020
@alikon
Copy link
Copy Markdown
Contributor

alikon commented Mar 28, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28487.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 28, 2020
@wilsonge wilsonge merged commit b838616 into joomla:4.0-dev Mar 28, 2020
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Mar 28, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 28, 2020
@Quy Quy deleted the 26638-modal-overflow branch March 28, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants