Skip to content

[4.0] convert to prepared statements User Table#28479

Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom
alikon:patch-116
Mar 27, 2020
Merged

[4.0] convert to prepared statements User Table#28479
wilsonge merged 3 commits intojoomla:4.0-devfrom
alikon:patch-116

Conversation

@alikon
Copy link
Copy Markdown
Contributor

@alikon alikon commented Mar 27, 2020

Summary of Changes

converted sql to prepared statements

Testing Instructions

  • create new users
  • delete users
  • modify users
  • register

Expected result

works as before

Actual result

N/A

Comment thread libraries/src/Table/User.php
@chmst
Copy link
Copy Markdown
Contributor

chmst commented Mar 27, 2020

I have tested this item ✅ successfully on d1924e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28479.

1 similar comment
@jwaisner
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on d1924e9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28479.

@jwaisner
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28479.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 27, 2020
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Mar 27, 2020

PHP Notice: Undefined variable: mapGroupId in \libraries\src\Table\User.php on line 398

PHP Warning: count(): Parameter must be an array or an object that implements Countable in \libraries\src\Table\User.php on line 398

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 27, 2020
@alikon
Copy link
Copy Markdown
Contributor Author

alikon commented Mar 27, 2020

notice/warning fixed

Comment thread libraries/src/Table/User.php Outdated
Co-Authored-By: Quy <quy@fluxbb.org>
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Mar 27, 2020

I have tested this item ✅ successfully on 8268a32


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28479.

@wilsonge wilsonge merged commit f22ed71 into joomla:4.0-dev Mar 27, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 27, 2020
@alikon alikon deleted the patch-116 branch March 28, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants