Fix typehints in library controllers#28477
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Mar 27, 2020
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 911f227 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28477. |
SharkyKZ
reviewed
Mar 27, 2020
|
I have tested this item ✅ successfully on 3b0eb70 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28477. 1st and 2nd one |
Contributor
Author
|
Thanks guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Now we have void typehints with our PHP 7.2 requirement we can add void typehints into the main library Controllers
Testing Instructions
Code review
Documentation Changes Required
None (these typehints are already in the code and will be documented appropriately)