[4.0] Change collations of com_finder tables to unicode on MySQL databases also in the component's install sql#28455
Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom Mar 25, 2020
Conversation
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #28425 (comment).
Summary of Changes
Same as in PR #28425 but for the component-specific install sql.
This is not really used anymore but still shall be kept up-to-date according to @wilsonge 's comment here: #28425 (comment).
For PostgreSQL only comments and code style have changed so it is more equal to the corresponding section in the joomla.sql file.
Testing Instructions
Code review:
Expected result
Files install.mysql.sql and install.postgresql.sql of com_finder are up-to-date with the changes in PR #28425 for joomla.sql.
Actual result
Files install.mysql.sql and install.postgresql.sql of com_finder are not up-to-date with the changes in PR #28425 for joomla.sql.
Documentation Changes Required
None.