[4.0] Break up tags code from category interface#28439
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Mar 26, 2020
Merged
[4.0] Break up tags code from category interface#28439wilsonge merged 1 commit intojoomla:4.0-devfrom
wilsonge merged 1 commit intojoomla:4.0-devfrom
Conversation
Contributor
|
played with tags and article and article category...... lgtm |
Contributor
|
I have tested this item ✅ successfully on af0ec82 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28439. |
1 similar comment
Member
|
I have tested this item ✅ successfully on af0ec82 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28439. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28439. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #24587 .
Summary of Changes
Breaks up tags code from the interface and adds a corresponding trait.
Note as it shares methods with the CategoryServiceTrait we have to choose to prioritize one of the methods (as they are identical I've arbitrarily chosen
CategoryServiceTraitbut there's no deeper reasoning for that decison)Testing Instructions
Check the count of items associated with a tag continues to work in the tags component when you filter by a tag type (e.g. article)
Documentation Changes Required
Yup. New tag interface needs to be documented