[4.0] Fix initial core data and code style in joomla.sql files#28424
Merged
wilsonge merged 8 commits intojoomla:4.0-devfrom Mar 24, 2020
Merged
Conversation
Quy
reviewed
Mar 22, 2020
Contributor
|
I have tested this item ✅ successfully on 7171556 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28424. |
Fix alphabetical order of extensions records for webservices plugins
…ial-core-data-for-postgresql
Member
Author
Quy
reviewed
Mar 22, 2020
Member
Author
|
@Quy Could you check again if all ok now? I hope I haven't missed one. |
Contributor
|
I have tested this item ✅ successfully on 8ae9896 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28424. |
Member
Author
Contributor
|
I have tested this item ✅ successfully on 8ae9896 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28424. |
Member
Author
|
@alikon Could you test again or review the PostgreSQL part? Thanks in advance. |
Contributor
|
I have tested this item ✅ successfully on 8ae9896 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28424. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28424. |
Member
Author
|
Thanks to all testers and reviewers. |
Contributor
|
Thanks for spending the time on this @richard67 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
This Pull Request changes the joomla.sql files for new installations for both kinds of databases.
MySQL (and MariaDB):
PostgreSQL:
Fix unneeded differences in data between PostgreSQL and MySQL and comments style.
The differences between the databases fixed by this PR are:
In the comments for the diverse sections in posgresql/joomla.sql, table names are in most cases quoted like on MySQL, only for a few recently added ones it was done differently. This PR unifies that so a comparison between the two joomla.sql files will not show difference in quotes in these comments.
Finally, fixed alphabetical order of extensions inserted for webservices plugins in the same way as for MySQL.
Testing Instructions
The test consists of 2 parts:
Instructions for part 1 - code review:
Instructions for part 2 - test new installation:
Expected result
After a new installation, the initial data inserted with joomla.sql is the same for MySQL and PostgreSQL databases.
Actual result
After a new installation, the initial data inserted with joomla.sql is different between MySQL and PostgreSQL databases. The differences are as described in the summary of changes.
Documentation Changes Required
None.