Skip to content

[4.0] Fix order of uninstallation of repeatable fields plugin#28399

Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom
wilsonge:fix-rep-uninstall
Mar 20, 2020
Merged

[4.0] Fix order of uninstallation of repeatable fields plugin#28399
wilsonge merged 2 commits intojoomla:4.0-devfrom
wilsonge:fix-rep-uninstall

Conversation

@wilsonge
Copy link
Copy Markdown
Contributor

@wilsonge wilsonge commented Mar 19, 2020 •
edited
Loading

Fixes #28385

Summary of Changes

Fixes the update of Joomla 3.10 to Joomla 4.0

Testing Instructions

Upgrade from 3.10 to 4.0. Before you get the error 0 Call to a member function attributes() on null because the manifest file for the repeatable fields plugin has been removed in the deleteUnexistingFiles function before the uninstallRepeatableFieldsPlugin. So I've just moved the uninstallation up the pecking order.

Documentation Changes Required

None

@wilsonge wilsonge changed the title Fix order of uninstallation of repeatable fields plugin [4.0] Fix order of uninstallation of repeatable fields plugin Mar 19, 2020
@wilsonge wilsonge mentioned this pull request Mar 19, 2020
Closed
Quy
Quy reviewed Mar 19, 2020
View reviewed changes
@richard67
Copy link
Copy Markdown
Member

richard67 commented Mar 19, 2020

Can’t do real test now, but review looks good. Correction fits to what was reported in PHP error log.

@wilsonge
Update administrator/components/com_admin/script.php
bdc74de 
Co-Authored-By: Quy <quy@fluxbb.org>
@richard67
Copy link
Copy Markdown
Member

richard67 commented Mar 20, 2020

I have tested this item ✅ successfully on bdc74de

Tested updating a current 3.10-dev branch to latest 4.0-dev nightly with following custom URLs:

The latter is the nightly of tonight plus the patch of this PR applied.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28399.

@richard67
Copy link
Copy Markdown
Member

richard67 commented Mar 20, 2020

Additional hint for other testers:

Without this PR applied, you get in addition to the error described in the description of this PR an error in your PHP error log (if that is switched on in your PHP settings):

PHP Warning: simplexml_load_file(): I/O warning : failed to load external entity "/home/richard/lamp/public_html/joomla-cms-3.10-dev/plugins/fields/repeatable/repeatable.xml"; in /home/richard/lamp/public_html/joomla-cms-3.10-dev/libraries/src/Installer/Installer.php on line 2034.

With this PR applied, this error disappears (but others might remains, which are not subject of this PR).

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Mar 20, 2020

I have tested this item ✅ successfully on bdc74de

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28399.

@alikon
Copy link
Copy Markdown
Contributor

alikon commented Mar 20, 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28399.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 20, 2020
@wilsonge wilsonge merged commit bb2b245 into joomla:4.0-dev Mar 20, 2020
@wilsonge
Copy link
Copy Markdown
Contributor Author

wilsonge commented Mar 20, 2020

Thanks guys!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 20, 2020
@wilsonge wilsonge deleted the fix-rep-uninstall branch March 20, 2020 10:48
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 20, 2020
@richard67
Copy link
Copy Markdown
Member

richard67 commented Mar 20, 2020

Thanks too, guy 😄

@richard67 richard67 mentioned this pull request Mar 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Quy Quy Quy left review comments

+1 more reviewer

@zero-24 zero-24 zero-24 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

6 participants

@wilsonge @richard67 @alikon @Quy @zero-24 @joomla-cms-bot