[4.0][api][com_content] remove notice when Multilingual#28384
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Mar 19, 2020
alikon:patch-116
Merged
[4.0][api][com_content] remove notice when Multilingual#28384wilsonge merged 2 commits intojoomla:4.0-devfrom alikon:patch-116
wilsonge merged 2 commits intojoomla:4.0-devfrom
alikon:patch-116
Conversation
Contributor
|
I have tested this item ✅ successfully on 5eca290 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28384. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 5eca290 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28384. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28384. |
Contributor
|
Just holding on merging this as need to reproduce. I think we may want to make multilang associations an empty array in this case rather than not render at all. BUT need to test to be sure :) |
Contributor
|
And do we want fulltext always loaded in backend? |
Contributor
|
We already started pulling out several properties to the api. fulltext isn't the end of the world. I don't like the associations fix but it's more related to how prepareItem works - think it needs to be aware of whether it's a list or item - but that's for a future PR. this will do for now |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redo of #27071 .
Summary of Changes
Testing Instructions
Expected result
no notice
Actual result
PHP Notice: Undefined property: stdClass::$fulltext in ../api/components/com_content/src/View/Articles/JsonapiView.php on line 149
PHP Notice: Undefined property: stdClass::$associations in /var/www/html/jbs4/api/components/com_content/src/View/Articles/JsonapiView.php on line 164
cc @wilsonge