Skip to content

[4.0] Remove adminlist.css#28372

Merged
wilsonge merged 5 commits intojoomla:4.0-devfrom
C-Lodder:adminlist
Mar 17, 2020
Merged

[4.0] Remove adminlist.css#28372
wilsonge merged 5 commits intojoomla:4.0-devfrom
C-Lodder:adminlist

Conversation

@C-Lodder
Copy link
Copy Markdown
Member

@C-Lodder C-Lodder commented Mar 16, 2020 •
edited
Loading

Pull Request for Issue # .

Summary of Changes

This PR removes an old CSS file. As far as I can tell, it's not used or needed.

Testing Instructions

  1. Login to the frontend of your Joomla site.
  2. Go to /index.php/submit-article
  3. In the TinyMCE editor toolbar, expand the CMS Content dropdown item and click Menu

This will display a modal.

Ensure the styling of the content

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Mar 16, 2020
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Mar 16, 2020

Remove use Joomla\CMS\HTML\HTMLHelper; in DisplayController.php files.

@C-Lodder
Copy link
Copy Markdown
Member Author

C-Lodder commented Mar 16, 2020

Thanks @Quy, done

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Mar 16, 2020

Not on desktop right now, but If I remember well, there was a class loaded in an xtd modal

@chmst
Copy link
Copy Markdown
Contributor

chmst commented Mar 16, 2020

I have tested this item ✅ successfully on d26f4c3

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28372.

1 similar comment
@ciar4n
Copy link
Copy Markdown
Contributor

ciar4n commented Mar 16, 2020

I have tested this item ✅ successfully on d26f4c3

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28372.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Mar 16, 2020

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28372.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 16, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Mar 16, 2020

@infograf768 can you please get back tomorrow morning on your checks

@C-Lodder
Copy link
Copy Markdown
Member Author

C-Lodder commented Mar 17, 2020 •
edited
Loading

I have checked the entire repo (PHP) code for references to adminlist after these changes. It's only used in PHP classes

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Mar 17, 2020

@C-Lodder @wilsonge

Here is an animated gif of the articles XTD used when editing an article in frontend.

adminlist

Screen Shot 2020-03-17 at 08 44 47

Remark the change in family font.

I am not saying we should keep adminlist because of that. It looks like it is indeed a useless override.

@brianteeman
Copy link
Copy Markdown
Contributor

brianteeman commented Mar 17, 2020

Good memory @infograf768

I agree with your conclusion that this change in font is not needed or even desired and this css can be removed

@wilsonge wilsonge merged commit 9e20bcd into joomla:4.0-dev Mar 17, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 17, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Mar 17, 2020

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 17, 2020
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Mar 17, 2020

Nice memory indeed JM!

@C-Lodder C-Lodder deleted the adminlist branch March 17, 2020 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Milestone

Joomla 4.0

Development

Successfully merging this pull request may close these issues.

8 participants

@C-Lodder @Quy @infograf768 @chmst @ciar4n @wilsonge @brianteeman @joomla-cms-bot