Skip to content

[4.0] Adapt Toolbar of messages to other toolbars#28369

Merged
infograf768 merged 2 commits intojoomla:4.0-devfrom
chmst:messages-toolbar
Mar 17, 2020
Merged

[4.0] Adapt Toolbar of messages to other toolbars#28369
infograf768 merged 2 commits intojoomla:4.0-devfrom
chmst:messages-toolbar

Conversation

@chmst
Copy link
Copy Markdown
Contributor

@chmst chmst commented Mar 16, 2020

Summary of Changes

The View of messages is adapted to other Toolbars

Now:
messages-action-buttons

After Patch:
messages-action-buttons2

Testing Instructions

Make at least one user with addmin-access,
send him a few messages.
Log in as this user.

See the Toolbar before and after Patch.

Make sure that all buttons are there and that they do their job.

Documentation Changes Required

screenshot

@infograf768
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on c95310f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28369.

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Mar 16, 2020

Note:
What do you think about normalising the status position as in other managers i.e. move it before the subject column.

Screen Shot 2020-03-16 at 12 26 28

@infograf768
Copy link
Copy Markdown
Member

Please correct cs
white spaces at end of lines

@chmst
Copy link
Copy Markdown
Contributor Author

chmst commented Mar 16, 2020

Good question. I don't know, as read / unread is a state but it has quite another meaning than published / unpublished. So maybe it is better to have the column not as usual, as it has another meaning as usual.
I don't like to have raped fields like here. .
Now we have in the headline "read" instead of "status" and if a item is trashed, there is the trash icon.
messages-action-buttons3

Really, I don't know. It's kind of UX issue

@infograf768
Copy link
Copy Markdown
Member

Definitely confusing between Trash and Read/Unread indeed.

@ChristineWk
Copy link
Copy Markdown

ChristineWk commented Mar 16, 2020

I have tested this item ✅ successfully on 070db96


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28369.
Ah, I saw the comments too late. Hv similar the same as on screenshot

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Mar 16, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28369.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 16, 2020
@infograf768 infograf768 merged commit 637a215 into joomla:4.0-dev Mar 17, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 17, 2020
@infograf768
Copy link
Copy Markdown
Member

tks

@infograf768 infograf768 added this to the Joomla 4.0 milestone Mar 17, 2020
@chmst chmst deleted the messages-toolbar branch April 19, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants