[4.0] Cleanup formvalidation uses#28352
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Mar 16, 2020
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 9d3b8f5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28352. |
Member
|
I have tested this item ✅ successfully on 9d3b8f5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28352. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28352. |
Contributor
Author
|
Cheers guys |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial Pull Request for Issue #25490 .
Summary of Changes
form-validateto various forms so that they are correctly used by the validator.data-cancel-taskattribute from com_config where we now no longer use core mvc and it follows the "normal" task patternBasically every form using the formvalidator behaviour is now associated with a form containing the
form-validateclass. (The password field additionally includes the behaviour without the class but that is outside the scope of the PR as the JS has a hard dependency)Testing Instructions
Ensure form validation in forms continues to work especially in the forms affected in this PR
Documentation Changes Required
None