[4.0] Rework CMS Application Interface tree#28313
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Mar 12, 2020
Merged
Conversation
8163a49 to
27c5e18
Compare
27c5e18 to
be5b3c7
Compare
Member
|
Increasing priority as this is a partial fix to a beta blocker. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28313. |
Member
|
Added back the beta-blocker label since the issue tracker has removed it, it seems, when priority was changed. |
be5b3c7 to
64ab7f8
Compare
Contributor
Author
|
Added a different interface for the stuff in the web interface - aim is we have CMSApplicationInterface which is for all application clients (mainly think cli plus web clients) then CMSWebApplicationInterface which covers the additional methods for web requests (api + html etc) |
64ab7f8 to
53410d4
Compare
Contributor
Author
|
Merging this as a first point. We may need to tweak things going forward |
4 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #24587 (only part).
Summary of Changes
Start reworking the CMS Application Interfaces onto the new interfaces introduced in the framework
Testing Instructions
Mainly Code review but you can check the Application still works without throwing missing function fatals (but that is the CIs job)
Documentation Changes Required
Yup - although there shouldn't be any breaks the interfaces need to be documented