Skip to content

[4.0] WIP on adding back ability to set site + admin languages in installer#27951

Closed
wilsonge wants to merge 1 commit intojoomla:4.0-devfrom
wilsonge:feature/installation-languages
Closed

[4.0] WIP on adding back ability to set site + admin languages in installer#27951
wilsonge wants to merge 1 commit intojoomla:4.0-devfrom
wilsonge:feature/installation-languages

Conversation

@wilsonge
Copy link
Copy Markdown
Contributor

@wilsonge wilsonge commented Feb 16, 2020

Related issue: #27059

Summary of Changes

WIP Work on adding back the ability to set site + admin languages in the installer. For now use the installer, install an extra language there. Then once installed successfully change your URL in the browser to <YOUR_JOOMLA_ROOT_URL>/installation/index.php?view=defaultlanguage (obviously this needs to be integrated into the flow see steps left below)

This reinstates back the old view for configuring the default site + admin languages - so that people who don't speak english as a native language are able to set the admin default language before they start to configure things.

Things left to do

  • Remove the installLocalisedContent options + related code - this will still belong in the administrator area
  • Figure out the flow of accessing this view (after installing a language an autoredirect or?)
  • Should this new view be merged with the existing installation install languages view
  • General Styling/ HTML Structure (This is give or take the same thing from J3 - I've just tweaked things to render via JForm and swapped to switcher)

Testing Instructions

TODO

Documentation Changes Required

N/A

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Feb 16, 2020
@wilsonge wilsonge mentioned this pull request Feb 16, 2020
Closed
@wilsonge wilsonge changed the title WIP on adding back ability to set site + admin languages [4.0] WIP on adding back ability to set site + admin languages in installer Feb 16, 2020
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Feb 16, 2020

Do you really want to add back installing multilingual sample data?
I am asking because, at looking at code, i see a new xml with the related fields.
I thought we should now only use the module/plugin.

@wilsonge
Copy link
Copy Markdown
Contributor Author

wilsonge commented Feb 16, 2020 •
edited
Loading

No I don’t. That’s why removing it is one of the items in my to do list ;)

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Feb 17, 2020

@wilsonge
Then please delete this new defaultlanguage.xml which only contains multilingual related stuff...
https://github.com/joomla/joomla-cms/pull/27951/files#diff-36940170e4e897341f3f5ac286af1332

@wilsonge
Copy link
Copy Markdown
Contributor Author

wilsonge commented Feb 17, 2020

Well I thought we'd still want activateMultilanguage and activatePluginLanguageCode?

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Feb 17, 2020

Well I thought we'd still want activateMultilanguage and activatePluginLanguageCode?

It includes installLocalisedContent. What is it for?

Please just take a final decision on what you want to install during J installation.

@astridx astridx mentioned this pull request Mar 12, 2020
Merged
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Mar 13, 2020

Closing as we have a working PR #28328

@wilsonge wilsonge deleted the feature/installation-languages branch March 15, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Language Change This is for Translators

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wilsonge @infograf768 @joomla-cms-bot