Move editAssociations code to regular save method#27941
Merged
infograf768 merged 1 commit intojoomla:stagingfrom Feb 16, 2020
Merged
Move editAssociations code to regular save method#27941infograf768 merged 1 commit intojoomla:stagingfrom
infograf768 merged 1 commit intojoomla:stagingfrom
Conversation
Member
|
@sanek4life Please thest. I'll test too tomorrow. |
Member
|
I have tested this item ✅ successfully on e89d1f5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27941. |
Contributor
|
I have tested this item ✅ successfully on e89d1f5 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27941. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27941. |
Member
|
Thanks @Bakual |
Member
|
Already merged. ;) Will be available in next release 3.9.16. |
What to do with other |
Contributor
Author
Yep, unfortunately there is no other way as the data is lost. Thanks for being stubborn with this issue. It was quite a bit hidden 😄 |
Member
|
@Bakual |
Contributor
|
Issue open #28310 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull Request for Issue #27921
Summary of Changes
The associations button in the article edit form triggered the
editAssocationstask. That task invoked a save method in the model and then redirected to the association manager.Unfortunately that save method bypassed everything done in the controller->save method. Resulting beside other potential issues in the issue above where the dateformat wasn't properly translated back.
This PR moves the code from the editAssociations method to the save method with a conditional on the active task.
in the controller, the "editAssociations" task is registered as a variant of the save method.
I have left the old "editAssociations" methods in the controller and model to keep B/C and added a deprecation note for 5.0.
Testing Instructions
Expected result
Date is still there
Actual result
Date is empty
Documentation Changes Required
None