Show correct message when uploaded file is too large#27730
Merged
rdeutz merged 7 commits intojoomla:stagingfrom Feb 3, 2020
SharkyKZ:j3/media-upload
Merged
Show correct message when uploaded file is too large#27730rdeutz merged 7 commits intojoomla:stagingfrom SharkyKZ:j3/media-upload
rdeutz merged 7 commits intojoomla:stagingfrom
SharkyKZ:j3/media-upload
Conversation
Member
|
@SharkyKZ With this PR applied and trying to upload a PHP file I get "Please input a file to upload." and not "You have tried to upload file(s) that are not safe." liike your instructions say. Before applying your PR it was like descibed in your instructions. |
Quy
reviewed
Jan 31, 2020
Contributor
Author
|
@richard67 Should work now. |
Member
|
I have tested this item ✅ successfully on 1c9e337 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27730. |
Quy
reviewed
Feb 2, 2020
Contributor
|
I have tested this item ✅ successfully on 1c9e337 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27730. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27730. |
Co-Authored-By: Quy <quy@fluxbb.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #27717.
Summary of Changes
Corrects error message when uploading too large files in
com_media.Testing Instructions
Expected result
Total size of upload exceeds the limit.You have tried to upload file(s) that are not safe.Actual result
You have tried to upload file(s) that are not safe.You have tried to upload file(s) that are not safe.Documentation Changes Required
No.